[PATCH] D36381: [MISched] Add enableMachineScheduler function that checks enable-misched.

Andrew Trick via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 7 10:47:52 PDT 2017


atrick added a comment.

I don't understand the motivation here. The purpose of command line flags is to test functionality in isolation. If you want a test case to control both SelectionDag and MISched functionality, then you use two command line flags.

The subtarget API controls the modes supported by the machine independent code. When a subtarget migrates to MachineScheduler it is supposed to migrate off SelectionDAG scheduling. Leaving both enabled is not something we ever intended to support and only hides problems with MachineScheduler.


https://reviews.llvm.org/D36381





More information about the llvm-commits mailing list