[PATCH] D33814: CodeGen: Fix ARM cmpxchg64 register fragmentation in fast-regalloc

Quentin Colombet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 7 10:37:57 PDT 2017


qcolombet added inline comments.


================
Comment at: lib/CodeGen/RegAllocFast.cpp:984
+      if (!MO.isUse())
+        continue;
+      VirtOps.emplace_back(i);
----------------
Reject Reg == 0


================
Comment at: lib/CodeGen/RegAllocFast.cpp:991
+                  unsigned Reg = MO.getReg();
+                  if (auto RC = MRI->getRegClassOrRegBank(Reg)) {
+                    if (RC.is<const TargetRegisterClass *>()) {
----------------
Why can't you just get the the reg class here?


https://reviews.llvm.org/D33814





More information about the llvm-commits mailing list