[PATCH] D36352: [LCG] Switch one of the update methods for the LazyCallGraph to support limited batch updates.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 6 16:19:31 PDT 2017


craig.topper added inline comments.


================
Comment at: include/llvm/Analysis/LazyCallGraph.h:807
     ///
-    /// 1) This RefSCC is still a RefSCC in the graph.
-    /// 2) This RefSCC will be the parent of any new RefSCCs. Thus, this RefSCC
-    ///    is preserved as the root of any new RefSCC DAG formed.
-    /// 3) No RefSCC other than this RefSCC has its member set changed (this is
+    /// 1) If a ref-cycle remains after removal, it leaves this RefSCC in tact
+    ///    and in the graph. No new RefSCCs are built.
----------------
'intact' is one word


================
Comment at: lib/Analysis/LazyCallGraph.cpp:1278
+  // sequence before the current RefSCC in that sequence, and then remove the
+  // currnt one.
   //
----------------
'current'


https://reviews.llvm.org/D36352





More information about the llvm-commits mailing list