[PATCH] D36372: [GPGPU] Make sure managed arrays are prepared at the beginning of the scop

Siddharth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 6 04:06:43 PDT 2017


bollu added a comment.

LGTM. I wish there was a simpler test case, but I can understand how it maybe hard to reduce it further.



================
Comment at: lib/CodeGen/PPCGCodeGeneration.cpp:790
+  assert(ManagedMemory &&
+         "Devise array most only be prepared in managed-memory mode");
+  for (int i = 0; i < Prog->n_array; ++i) {
----------------
Nit: `Devise` -> `Device`. `most only be...` -> `must only be...`.


https://reviews.llvm.org/D36372





More information about the llvm-commits mailing list