[PATCH] D35945: [ELF] - Linkerscript: better diagnostic for INPUT/GROUP commands.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 4 22:37:59 PDT 2017


ruiu added inline comments.


================
Comment at: ELF/ScriptParser.cpp:280
+
+  if (ErrorCount)
+    error(">>> location:" + getCurrentLocation());
----------------
I don't think this is enough. You want to check if ErrorCount is incremented in this function.


https://reviews.llvm.org/D35945





More information about the llvm-commits mailing list