[llvm] r310077 - Fixing buildbots: do not register check-fuzzer if clang or asan are not

[George Karpenkov via llvm-commits]

indeed, if(TARGET) seems order-dependent, and hence I don’t know now how to check whether asan/clang targets exist
at the time when CMake for libFuzzer runs.
Maybe just make the check-fuzzer registration opt-in? (E.g. one would have to run cmake -DINCLUDE_LIBFUZZER_TESTS=ON )

> On Aug 4, 2017, at 12:15 PM, George Karpenkov via llvm-commits <llvm-commits at lists.llvm.org> wrote:
> 
> looking into this now.
>> On Aug 4, 2017, at 12:05 PM, Kostya Serebryany <kcc at google.com <mailto:kcc at google.com>> wrote:
>> 
>> Ping. Are you looking into this? 
>> 
>> On Fri, Aug 4, 2017 at 11:31 AM, Kostya Serebryany <kcc at google.com <mailto:kcc at google.com>> wrote:
>> ... from *all* builds 
>> 
>> On Fri, Aug 4, 2017 at 11:31 AM, Kostya Serebryany <kcc at google.com <mailto:kcc at google.com>> wrote:
>> I think this removed check-fuzzer from old build, at least I get this: 
>> ninja: error: unknown target 'check-fuzzer'
>> 
>> 
>> On Fri, Aug 4, 2017 at 10:43 AM, George Karpenkov via llvm-commits <llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>> wrote:
>> Author: george.karpenkov
>> Date: Fri Aug  4 10:43:29 2017
>> New Revision: 310077
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=310077&view=rev <http://llvm.org/viewvc/llvm-project?rev=310077&view=rev>
>> Log:
>> Fixing buildbots: do not register check-fuzzer if clang or asan are not
>> present.
>> 
>> Modified:
>>     llvm/trunk/lib/Fuzzer/test/CMakeLists.txt
>> 
>> Modified: llvm/trunk/lib/Fuzzer/test/CMakeLists.txt
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Fuzzer/test/CMakeLists.txt?rev=310077&r1=310076&r2=310077&view=diff <http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Fuzzer/test/CMakeLists.txt?rev=310077&r1=310076&r2=310077&view=diff>
>> ==============================================================================
>> --- llvm/trunk/lib/Fuzzer/test/CMakeLists.txt (original)
>> +++ llvm/trunk/lib/Fuzzer/test/CMakeLists.txt Fri Aug  4 10:43:29 2017
>> @@ -47,20 +47,23 @@ include_directories(..)
>>  set(LIBFUZZER_TEST_COMPILER ${LLVM_RUNTIME_OUTPUT_INTDIR}/clang)
>>  set(LIBFUZZER_TEST_CXX_COMPILER ${LLVM_RUNTIME_OUTPUT_INTDIR}/clang++)
>> 
>> -# LIT-based libFuzzer tests.
>> -configure_lit_site_cfg(
>> -  ${CMAKE_CURRENT_SOURCE_DIR}/lit.site.cfg.in <http://lit.site.cfg.in/>
>> -  ${CMAKE_CURRENT_BINARY_DIR}/lit.site.cfg
>> -  )
>> +if ((TARGET asan) AND (TARGET clang))
>> +  # LIT-based libFuzzer tests.
>> +  configure_lit_site_cfg(
>> +    ${CMAKE_CURRENT_SOURCE_DIR}/lit.site.cfg.in <http://lit.site.cfg.in/>
>> +    ${CMAKE_CURRENT_BINARY_DIR}/lit.site.cfg
>> +    )
>> 
>> -# libFuzzer unit tests.
>> -configure_lit_site_cfg(
>> -  ${CMAKE_CURRENT_SOURCE_DIR}/unit/lit.site.cfg.in <http://lit.site.cfg.in/>
>> -  ${CMAKE_CURRENT_BINARY_DIR}/unit/lit.site.cfg
>> -  )
>> +  # libFuzzer unit tests.
>> +  configure_lit_site_cfg(
>> +    ${CMAKE_CURRENT_SOURCE_DIR}/unit/lit.site.cfg.in <http://lit.site.cfg.in/>
>> +    ${CMAKE_CURRENT_BINARY_DIR}/unit/lit.site.cfg
>> +    )
>> 
>> -add_lit_testsuite(check-fuzzer "Running Fuzzer tests"
>> +  add_lit_testsuite(check-fuzzer "Running Fuzzer tests"
>>      ${CMAKE_CURRENT_BINARY_DIR}
>>      DEPENDS LLVMFuzzer-Unittest)
>> 
>> -add_dependencies(check-fuzzer LLVMFuzzer asan clang llvm-symbolizer FileCheck sancov not)
>> +  add_dependencies(check-fuzzer LLVMFuzzer asan clang llvm-symbolizer FileCheck sancov not)
>> +endif()
>> +
>> 
>> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits <http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits>
>> 
>> 
>> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170804/08da43c0/attachment.html>