[PATCH] D36207: [compiler-rt] Check for empty buffer in Addr2LineProcess::ReadFromSymbolizer

[David Lam via Phabricator via llvm-commits]

david-y-lam marked an inline comment as done.
david-y-lam added inline comments.


================
Comment at: lib/sanitizer_common/sanitizer_symbolizer_posix_libcdep.cc:276
+    // If buffer is empty and null-terminated, then input is longer than
+    // max_length, so simply skip this frame by returning.
+    if (*buffer == '\0')
----------------
alekseyshl wrote:
> // The returned buffer is empty when output is valid, but exceeds max_length.
> 
> We're not skipping the frame, we just not looking for output_terminator_ in it.
that's a better comment, will amend.


Repository:
  rL LLVM

https://reviews.llvm.org/D36207