[PATCH] D36211: [cmake] Expose the dependencies of ExecutionEngine as PUBLIC

NAKAMURA Takumi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 3 16:02:35 PDT 2017


chapuni requested changes to this revision.
chapuni added a comment.
This revision now requires changes to proceed.

In another perspective, it might be inappropriate that SectionMemoryManager is here.

SectionMemoryManager depends on RuntimeDyld, but doesn't depend no other compilation units in ExecutionEngine.
Users of SectionMemoryManager don't require LLVMRuntimeDyld.
As I mentioned above, the implementer of derived class of SectionMemoryManager depend on LLVMRuntimeDyld.

It might be an option to move SectionMemoryManager into RuntimeDyld. I am not sure if it were proper, though.

Anyways, I think such a hack should be introduced if it were the last resort, or you might abandon using PRIVATE for SHARED to use PUBLIC to entire SHARED.
I strongly suggest to fix lldb.


Repository:
  rL LLVM

https://reviews.llvm.org/D36211





More information about the llvm-commits mailing list