[PATCH] D36288: Use profile summary to disable peeling for huge working sets

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 3 15:55:32 PDT 2017


tejohnson added a comment.

In https://reviews.llvm.org/D36288#831144, @davidxl wrote:

> Have we considered limiting the max number of peeled iterations instead of  disabling it?


I am planning to do some follow on tuning that would limit the factor based on additional profile info, but as a first heuristic disabling it helps quite a bit.



================
Comment at: lib/Analysis/ProfileSummaryInfo.cpp:69
+// Find the number of counts to reach a desired percentile of counts.
+static uint64_t getNumCountsForPercentile(SummaryEntryVector &DS,
+                                          uint64_t Percentile) {
----------------
eraman wrote:
> The getMinCountForPercentile and getNumCountsForPercentile could be merged to a getEntryForPercentile
That's a good idea, will do so.


https://reviews.llvm.org/D36288





More information about the llvm-commits mailing list