[PATCH] D36167: [Dominators] Introduce batch updates

Jakub Kuderski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 3 08:31:48 PDT 2017


kuhar added a comment.

In https://reviews.llvm.org/D36167#830596, @brzycki wrote:

> Kuba, I saw your comments saying the new interface is, in general, more efficient to apply a single batch update vs Insert/Delete. Is it worth the effort for callers to *not* call .applyUpdates() when we know our vector is of size = 1?


In that case, the batch updater would do a fair bit of set up work, so I'd recommend calling insert/deleteEdge directly. It should be possible to make this a special case in the batch updater, but I'm not sure if that'd make a real-world difference anywhere.


https://reviews.llvm.org/D36167





More information about the llvm-commits mailing list