[PATCH] D36248: [AArch64] Fix an assertion for pre-index generation with unscaled loads/stores.

Jun Bum Lim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 3 08:18:14 PDT 2017

Previous message: [PATCH] D36248: [AArch64] Fix an assertion for pre-index generation with unscaled loads/stores.
Next message: [PATCH] D36248: [AArch64] Fix an assertion for pre-index generation with unscaled loads/stores.
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

junbuml added a comment.

LGTM. 
It seems that those are simply missing opcodes in the switch.

It might be good to add FIXME in getPreIndexedOpcode explaining  unscaled loads/stores are intentionally not added for now.


https://reviews.llvm.org/D36248

Previous message: [PATCH] D36248: [AArch64] Fix an assertion for pre-index generation with unscaled loads/stores.
Next message: [PATCH] D36248: [AArch64] Fix an assertion for pre-index generation with unscaled loads/stores.
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list