[PATCH] D35843: [ELF] - Fix "--symbol-ordering-file doesn't work with linker scripts"

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 3 03:37:32 PDT 2017


>This LGTM.
>
>I think there are two potential improvements, but they can be done as
>followups:
>
>* Removing the switch over  Config->EKind. This depends on D35936.

And also on D35987.

>* Moving the sort out of LinkerScript::computeInputSections.
>
>The second one should allow sharing the code path for the script and non
>script cases.
>
>Cheers,
>Rafael

Sounds reasonable.

Rui, are you ok to land this ?

George.


More information about the llvm-commits mailing list