[PATCH] D36190: [asan] Allocator support for Fuchsia

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added inline comments.


================
Comment at: lib/asan/asan_malloc_linux.cc:56
+#else
+  return UNLIKELY(asan_init_is_running);
+#endif
----------------
vitalybuka wrote:
> mcgrathr wrote:
> > vitalybuka wrote:
> > > Why do you need to ifdef this?
> > > I'd expect that asan_init_is_running will be false on fuchsia anyway
> > It will always be false at runtime, but the compiler can't tell that statically.
> > I want the dead code (and its static data bloat) to be compiled out, which it is with this.
> could you please remove ifdef then? We don't like them only when no other options.
> We can add them later if it cause real problems.
actually just undo MaybeInDlsym change


https://reviews.llvm.org/D36190