[PATCH] D34048: [PowerPC] Eliminate compares - add i32 sext/zext handling for SETLE/SETGE

Nemanja Ivanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 2 03:31:45 PDT 2017


nemanjai added inline comments.


================
Comment at: lib/Target/PowerPC/PPCISelDAGToDAG.cpp:2890
+  bool IsRHSOne = RHSValue == 1;
+  bool IsRHSNegOne = RHSValue == -1LL;
   switch (CC) {
----------------
`IsRHSOne/IsRHSNegOne` are not currently used but will be used to produce the `LHS <= 0` sequence for `LHS < 1` and the `LHS >= 0` sequence for `LHS > -1` in a subsequent patch.

Rather than omitting them from this patch and the function that re-sets them, I left them in. This way if this isn't how we want to implement `swapAndReset()`, I can address it in this patch rather than having to re-work it in the next.


Repository:
  rL LLVM

https://reviews.llvm.org/D34048





More information about the llvm-commits mailing list