[PATCH] D36212: [lit] Use Visual Studio build config when testing

[Greg Bedwell via Phabricator via llvm-commits]

gbedwell added inline comments.


================
Comment at: utils/lit/tests/CMakeLists.txt:26
+  # find these executables, pass --build_configuration as a --param.
+  PARAMS build_configuration=$<CONFIG>
 )
----------------
add_lit_target in AddLLVM.cmake already appends "--param build_mode=${CMAKE_CFG_INTDIR}" to the lit args so you should be able to just make use of that param rather than adding a new one.


================
Comment at: utils/lit/tests/lit.cfg:72
+    build_configuration = lit_config.params.get('build_configuration', None)
+    if is_windows and build_configuration is not None:
+        # When using a Visual Studio CMake generator, at the time that lit.site.cfg.in
----------------
This isn't a Windows/Visual Studio specific issue, but a multi-config CMake generator issue.  The ones I'm aware of are Visual Studio and Xcode, but there may be others (see https://cmake.org/cmake/help/v3.9/variable/CMAKE_CFG_INTDIR.html ) so I don't think this should be limited on is_windows.


https://reviews.llvm.org/D36212