[PATCH] D36049: [Resubmitted] Remove uses of deprecated std::unary_function, binary_function, and pointer_to_unary_function.

Saleem Abdulrasool via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 1 20:23:24 PDT 2017


compnerd added inline comments.


================
Comment at: include/llvm/ADT/STLExtras.h:61-62
+struct identity {
+  using argument_type = Ty;
+  using result_type = Ty;
+
----------------
dblaikie wrote:
> Should these changes be adding all these typedefs? I assume the reason std::unary_function et. al. are deprecated is that callers should likely be using decltype & similar things to work here instead?
Well, doing it this way makes it a NFC change.  Plus, doing something like decltype to get the argument types adds a bit of unnecessary complexity though.


https://reviews.llvm.org/D36049





More information about the llvm-commits mailing list