[PATCH] D36134: [ARM] Improve loop unrolling for Cortex-M

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

Diff is missing context.



================
Comment at: lib/Target/ARM/ARMTargetTransformInfo.cpp:596
+               isa<BranchInst>(I))
+      continue;
+    ++NumInsts;
----------------
getUserCost()?


================
Comment at: lib/Target/ARM/ARMTargetTransformInfo.cpp:623
+    if (isa<SCEVCouldNotCompute>(Count) || !Count->getType()->isIntegerTy())
+      UP.DefaultUnrollRuntimeCount = 4;
+  }
----------------
Have you experimented with setting "UP.Runtime = false"?


https://reviews.llvm.org/D36134