[PATCH] D35829: [X86][LLVM]Expanding Supports lowerInterleavedStore() in X86InterleavedAccess (VF16 stride 4).

[David Kreitzer via Phabricator via llvm-commits]

DavidKreitzer added inline comments.


================
Comment at: lib/Target/X86/X86InterleavedAccess.cpp:132
+  if (!Subtarget.hasAVX() || Factor != 4 || ShuffleElemSize != 64 ||
       WideInstSize != (Factor * ShuffleElemSize * SupportedNumElem))
     return false;
----------------
guyblank wrote:
> so this check isn't needed in the previous if?
> 
> Can you try to simplify this function? its getting overly complicated IMO.
> Can you try to simplify this function? its getting overly complicated IMO.

+1
I would personally be fine with doing that in an NFC follow-up patch.

Otherwise, this LGTM.


https://reviews.llvm.org/D35829