[PATCH] D36114: [AsmPrinterDwarf] Add support for .cfi_restore directive

Francis Visoiu Mistrih via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 1 11:11:46 PDT 2017


thegameg marked 4 inline comments as done.
thegameg added inline comments.


================
Comment at: lib/CodeGen/MIRPrinter.cpp:1214
+    if (CFI.getLabel())
+      OS << "<mcsymbol> ";
+    printCFIRegister(CFI.getRegister(), OS, TRI);
----------------
probinson wrote:
> I didn't see a test for this bit here.
The MIRParser doesn't attach any symbols to the MCCFIInstructions it creates ([[ https://github.com/llvm-mirror/llvm/blob/9bf66c7/lib/CodeGen/MIRParser/MIParser.cpp#L1544 | lib/CodeGen/MIRParser/MIParser.cpp:MIParser::parseCFIOperand ]], and since we don't emit any `.cfi_restore` directives yet, I can't add a test for this.


https://reviews.llvm.org/D36114





More information about the llvm-commits mailing list