[PATCH] D36117: [DebugInfo] Don't turn dbg.declare into DBG_VALUE for static allocas

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 1 10:47:21 PDT 2017


rnk marked 3 inline comments as done.
rnk added inline comments.


================
Comment at: llvm/test/DebugInfo/WebAssembly/dbg-declare.ll:3
 ; RUN: llc < %s -verify-machineinstrs -mtriple=wasm32-unknown-unknown-wasm -fast-isel | FileCheck --check-prefix=CHECK-FAST %s
-; CHECK: #DEBUG_VALUE: decode:i <- [%vreg
-; CHECK: #DEBUG_VALUE: decode:v <- [%vreg
 ; CHECK: DW_TAG_variable
 ; CHECK-FAST: DW_TAG_variable
----------------
aprantl wrote:
> When removing the check for the DEBUG_VALUE, could you add a check for the actual variable location being emitted via the MMI side table? `llc -filetype=obj | llvm-dwarfdump -` and a check for a DW_AT_name / DW_AT_location pair should do the trick.
llvm-dwarfdump doesn't appear to know how to parse wasm object files, so I can't add that check. I can add the DW_AT_location checks to the other tests, though.


https://reviews.llvm.org/D36117





More information about the llvm-commits mailing list