[PATCH] D36119: [CMake][LLVM] Remove duplicated library mask. Broken clang linking against clangShared

[Oleg Ranevskyy via Phabricator via llvm-commits]

iid_iunknown created this revision.
Herald added subscribers: kristof.beyls, mgorny, aemerson.

The `LLVM${c}Info` mask is listed twice in LLVM-Config.cmake. This results in the libraries such as LLVMARMInfo, LLVMAArch4Info, etc appearing twice in `extract_symbols.py` command line while building `clangShared`. `Extract_symbols.py` does not work well in such a case and completely ignores the symbols from the duplicated libraries. Thus, the LLVM(...)Info symbols do not get exported from `clangShared` and linking clang against it fails with unresolved dependencies.

Seems to be a mere copy-paste mistake.


Repository:
  rL LLVM

https://reviews.llvm.org/D36119

Files:
  cmake/modules/LLVM-Config.cmake


Index: cmake/modules/LLVM-Config.cmake
===================================================================
--- cmake/modules/LLVM-Config.cmake
+++ cmake/modules/LLVM-Config.cmake
@@ -190,9 +190,6 @@
       if( TARGET LLVM${c}Disassembler )
         list(APPEND expanded_components "LLVM${c}Disassembler")
       endif()
-      if( TARGET LLVM${c}Info )
-        list(APPEND expanded_components "LLVM${c}Info")
-      endif()
       if( TARGET LLVM${c}Utils )
         list(APPEND expanded_components "LLVM${c}Utils")
       endif()


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D36119.109006.patch
Type: text/x-patch
Size: 541 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170731/6d007685/attachment.bin>