[PATCH] D35851: [Dominators] Include infinite loops in PostDominatorTree

Daniel Berlin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 31 08:48:18 PDT 2017


dberlin added inline comments.


================
Comment at: test/Transforms/StructurizeCFG/no-branch-to-entry.ll:1
+; XFAIL: *
 ; RUN: opt -S -o - -structurizecfg -verify-dom-info < %s | FileCheck %s
----------------
grosser wrote:
> Why was this XFAILed? Could you potentially add a comment why this test cases does not work any more?
This is probably copied from my original patch.

It used to generate a region that caused it to try to replace the entry block, but it does not anymore.
I had left it xfailed and pinged the structurizer maintainer to see if he could generate a case where it still tried to replace the entry block.
I believe it to not be possible anymore, but i couldn't be sure.

So the short version is: "This test will probably end up removed, but i wanted to give it a little time"


https://reviews.llvm.org/D35851





More information about the llvm-commits mailing list