[PATCH] D34559: [X86][DAG] Switch X86 Target to post-legalized store merge

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 31 05:50:29 PDT 2017


RKSimon added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAGAddressAnalysis.cpp:61
   // (((B + I*M) + c)) + c ...
-  SDValue Base = Ptr;
+  SDValue Base = TLI.unwrapAddress(Ptr);
   SDValue Index = SDValue();
----------------
One use and fits on the line, so we can just do:
```
SDValue Base = DAG.getTargetLoweringInfo().unwrapAddress(Ptr);
```


================
Comment at: test/CodeGen/X86/bitcast-i256.ll:25
+; CHECK: vmovups
+; CHECK: ret
 }
----------------
Get rid of this - did the script add it?


https://reviews.llvm.org/D34559





More information about the llvm-commits mailing list