[PATCH] D36054: Emit only A Single Opt Remark When Inlining
Adam Nemet via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Jul 30 22:19:34 PDT 2017
anemet added a reviewer: davidxl.
anemet added inline comments.
Comment at: lib/Transforms/IPO/Inliner.cpp:557
// Get DebugLoc to report. CS will be invalid after Inliner.
+ InlineCost IC = GetInlineCost(CS);
DebugLoc DLoc = Instr->getDebugLoc();
> I'm not sure of the overhead of re-computing the InlineCost, which is used below. Maybe I should also return it (using an output parameter) from `shouldInline` above?
Yes, that is what I was thinking of doing.
More information about the llvm-commits