[llvm] r309515 - Revert "[AVR] Mark a failing symbolizer test as XFAIL"
David Blaikie via llvm-commits
llvm-commits at lists.llvm.org
Sun Jul 30 09:10:24 PDT 2017
That said, redaing the bug, XFAILing for AVR doesn't seem like the right
answer - sounds like this would be failing on any Debian machine, AVR, X86,
etc. (so XFAIL AVR would have false positives an false negatives - there
could be AVR machines where this passes, and non-AVR machines where it
Sounds like the test should be fixed.
On Sun, Jul 30, 2017 at 9:08 AM David Blaikie <dblaikie at gmail.com> wrote:
> On Sun, Jul 30, 2017 at 8:38 AM Dylan McKay via llvm-commits <
> llvm-commits at lists.llvm.org> wrote:
>> Author: dylanmckay
>> Date: Sun Jul 30 08:38:07 2017
>> New Revision: 309515
>> URL: http://llvm.org/viewvc/llvm-project?rev=309515&view=rev
>> Revert "[AVR] Mark a failing symbolizer test as XFAIL"
>> This reverts commit 83a0e876349adb646ba858eb177b22b0b4bfc59a.
> Please use SVN revision numbers rather than git hashes in commits
> There's a handy utility to help with this in
> llvm/utils/git-svn/git-svnrevert - it'll take a git hash to revert, but
> create a local commit with the SVN revision in the commit message instead.
> Also, I committed a change in r309516 that'll make this test resilient to
> your change. (so adding the comment lines doesn't throw off the test's
> checks for line numbers, etc) So you can probably recommit it.
> (that said, this is probably a bad test - generally good to avoid running
> the host compiler to test functionality - most of the llvm-symbolizer tests
> rely on checked in binaries to run over)
> - Dave
>> Modified: llvm/trunk/test/tools/llvm-symbolizer/print_context.c
>> --- llvm/trunk/test/tools/llvm-symbolizer/print_context.c (original)
>> +++ llvm/trunk/test/tools/llvm-symbolizer/print_context.c Sun Jul 30
>> 08:38:07 2017
>> @@ -1,9 +1,6 @@
>> // REQUIRES: x86_64-linux
>> // RUN: %host_cc -O0 -g %s -o %t 2>&1
>> // RUN: %t 2>&1 | llvm-symbolizer -print-source-context-lines=5 -obj=%t
>> | FileCheck %s
>> -// See PR31870 for more details on the XFAIL
>> -// XFAIL: avr
>> #include <stdio.h>
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-commits