[PATCH] D36052: Update the new PM pipeline to make ICP aware if it is SamplePGO build.

[Dehao Chen via Phabricator via llvm-commits]

danielcdh added a comment.

In https://reviews.llvm.org/D36052#825318, @davidxl wrote:

> Instr PGO has its own set of simplification passes, but still I think we should keep this patch NFC for instrPGO. If there are performance numbers that justify the InstrPGO pipeline changes, it can be discussed/done in a separate thread.  This one should be left as SamplePGO only change.


The tricky part is that PGOOptions was not passed in the ThinLTO backend before this patch. But after this patch, it will be passed in. However, in buildModuleSimplificationPipeline, it cannot know if this is the ThinLTO backend. As a result, we cannot disable instrumentation/annotation pass in there.

The potential solution could be:

- add another boolean value in buildModuleSimplificationPipeline to indicate it's ThinLTO backend
- refactor the code from the beginning of buildModuleSimplificationPipeline to the PGOOpt handling to a separate function, and call it separately in the caller of buildModuleSimplificationPipeline.

Any suggestions on how to move forward?

Thanks,
Dehao


https://reviews.llvm.org/D36052