[PATCH] D35800: Improve readability of CXX method overrides list

Phabricator via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jul 29 13:43:38 PDT 2017


This revision was automatically updated to reflect the committed changes.
Closed by commit rL309496: Improve readability of CXX method overrides list (authored by lll).

Changed prior to commit:
  https://reviews.llvm.org/D35800?vs=107902&id=108803#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D35800

Files:
  cfe/trunk/lib/AST/ASTDumper.cpp


Index: cfe/trunk/lib/AST/ASTDumper.cpp
===================================================================
--- cfe/trunk/lib/AST/ASTDumper.cpp
+++ cfe/trunk/lib/AST/ASTDumper.cpp
@@ -1184,7 +1184,7 @@
          I != E; ++I)
       dumpCXXCtorInitializer(*I);
 
-  if (const CXXMethodDecl *MD = dyn_cast<CXXMethodDecl>(D))
+  if (const CXXMethodDecl *MD = dyn_cast<CXXMethodDecl>(D)) {
     if (MD->size_overridden_methods() != 0) {
       auto dumpOverride =
         [=](const CXXMethodDecl *D) {
@@ -1199,11 +1199,14 @@
         dumpOverride(*FirstOverrideItr);
         for (const auto *Override :
                llvm::make_range(FirstOverrideItr + 1,
-                                MD->end_overridden_methods()))
+                                MD->end_overridden_methods())) {
+          OS << ", ";
           dumpOverride(Override);
+        }
         OS << " ]";
       });
     }
+  }
 
   if (D->doesThisDeclarationHaveABody())
     dumpStmt(D->getBody());


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D35800.108803.patch
Type: text/x-patch
Size: 972 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170729/6aa4beaf/attachment.bin>


More information about the llvm-commits mailing list