[PATCH] D35789: [XRay][compiler-rt] Do not print the warning when the binary is not XRay instrumented.

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jul 29 10:35:09 PDT 2017


dblaikie added a comment.

Testing looks OK - but the change doesn't seem to match the description. I'm guessing there's existing code to SetVerbosity depending on whether the binary is instrumented or not? & there are tests for that?

If so, then maybe this could use a different description that better matches the code change? (Don't print warning about missing instrumentation when verbosity is zero?)


https://reviews.llvm.org/D35789





More information about the llvm-commits mailing list