[PATCH] D35101: [cfi] only add cfi tests on supported arches

[Evgenii Stepanov via Phabricator via llvm-commits]

eugenis added inline comments.


================
Comment at: test/cfi/CMakeLists.txt:42
+  foreach(arch ${CFI_TEST_ARCH})
+    if (COMPILER_RT_HAS_CFI AND ";${CFI_SUPPORTED_ARCH};" MATCHES ";${arch};")
+      add_cfi_test_suites(False False)
----------------
CFI_TEST_ARCH is set to CFI_SUPPORTED_ARCH. Why are you testing that ${arch} is in CFI_SUPPORTED_ARCH here?


================
Comment at: test/cfi/CMakeLists.txt:44
+      add_cfi_test_suites(False False)
+      add_cfi_test_suites(False True)
+      if (COMPILER_RT_HAS_LLD)
----------------
If there are multiple supported arches, like i686 and x86_64, this would create exactly the same test suites twice, right?



Repository:
  rL LLVM

https://reviews.llvm.org/D35101