[PATCH] D36031: [sanitizer_common] Fuchsia OS support code

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 28 16:24:53 PDT 2017

vitalybuka accepted this revision.
vitalybuka added a comment.
This revision is now accepted and ready to land.

I looked sanitizer_fuchsia.cc very briefly.
The rest LGTM

Comment at: lib/sanitizer_common/sanitizer_printf.cc:260
+    // Fuchsia's logging infrastructure always keeps track of the logging
+    // process, thread, and timestamp, so never prepend such information.
+    if (!SANITIZER_FUCHSIA && append_pid) {
I guess you would like to enabled as many as possible compiler-rt tests in future
So maybe better to avoid diverging if this is not critical?



More information about the llvm-commits mailing list