[PATCH] D36025: Do not want to use BFI to get profile count for sample pgo

Dehao Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 28 16:17:58 PDT 2017


danielcdh added a comment.

In https://reviews.llvm.org/D36025#824892, @eraman wrote:

> If the profile count based on BFI is completely reliable that you are discarding it, then shouldn't BFI->getProfileCount also return 0 for sampled profiling? I think this can end up in surprising behavior.


We only want to do this on callsites, as we still rely on BFI to get other block frequencies.


https://reviews.llvm.org/D36025





More information about the llvm-commits mailing list