[PATCH] D36032: [sanitizer_common] Fuchsia-specific symbolizer

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added inline comments.


================
Comment at: lib/sanitizer_common/sanitizer_stacktrace_printer.cc:128
 
 void RenderData(InternalScopedString *buffer, const char *format,
                 const DataInfo *DI, const char *strip_path_prefix) {
----------------
How about having implementation of RenderFrame and RenderData in sanitizer_symbolizer_fuchsia.cc?

#if !FUCHSIA
void RenderFrame(InternalScopedString *buffer, const char *format, int frame_no,
                 const AddressInfo &info, bool vs_style,
                 const char *strip_path_prefix, const char *strip_func_prefix) {
...

}

void RenderData(InternalScopedString *buffer, const char *format,
....
}
#endif


Repository:
  rL LLVM

https://reviews.llvm.org/D36032