[PATCH] D35979: [X86] Fix a crash in FEntryInserter Pass.

[Manoj Gupta via Phabricator via llvm-commits]

manojgupta marked 3 inline comments as done.
manojgupta added a comment.

David, your comment didn't make it here. So adding it myself.

The call to fentry is unconditionally added to the beginning of function.  Should the call use the same debug location of the previous instruction if present?

On Fri, Jul 28, 2017 at 10:33 AM, David Blaikie <dblaikie at gmail.com> wrote:

Depends what you mean by "unrelated" - if the new instruction is created because of/only in the presence of the old instruction, yaeh, using its debugloc may be appropriate. (Though if the new instruction may be created in a different basic block - that gets trickier)


https://reviews.llvm.org/D35979