[PATCH] D35742: [Driver] Register effective triple before get arm float abi.

Leo Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 28 10:02:26 PDT 2017

aoli added a comment.

> - It isn't obvious from the context of Driver.cpp why ComputeEffectiveTriple() needs to be called. After a bit of searching I found the call to getArchNameForCompilerRTLib that contained the call to getARMFloatABI. Is is worth moving the call to ComputeEffectiveTriple just before the call to `()?

I was also thinking about that but it seems that `ToolChain::getCompilerRT` is also being called by many other functions. If we register effective triple right before the call to `getARMFloatABI` it will replace the origin `EffectiveTriple` in `Toolchain`. This may cause some side effects we don't want.


More information about the llvm-commits mailing list