[PATCH] D35703: [GPGPU] Add support for NVIDIA libdevice

Siddharth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 28 05:13:50 PDT 2017


bollu added inline comments.


================
Comment at: lib/CodeGen/PPCGCodeGeneration.cpp:1341
+/// A list of functions that are available in NVIDIA's libdevice.
+std::set<std::string> CUDALibDeviceFunctions = {"exp",  "expf", "expl", "cos",
+                                                "cosf", "sqrt", "sqrtf"};
----------------
bollu wrote:
> this can be `const std::set<std::string> ...` ? I do not see us mutating this, and it would be nice to communicate this fact.
Could you also add `copysign`, please?


https://reviews.llvm.org/D35703





More information about the llvm-commits mailing list