[llvm] r309346 - Changing the default MaxNumPromotions from 2 to 3.

Dehao Chen via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 27 18:03:10 PDT 2017


Author: dehao
Date: Thu Jul 27 18:03:10 2017
New Revision: 309346

URL: http://llvm.org/viewvc/llvm-project?rev=309346&view=rev
Log:
Changing the default MaxNumPromotions from 2 to 3.

Summary: In performance tuning, we see performance benefits when enlarge the maximum num promotion targets to 3. This is safe as soon as we have total percentage threshold properly setup (https://reviews.llvm.org/D35962)

Reviewers: davidxl, tejohnson

Reviewed By: tejohnson

Subscribers: llvm-commits, sanjoy

Differential Revision: https://reviews.llvm.org/D35966

Modified:
    llvm/trunk/lib/Analysis/IndirectCallPromotionAnalysis.cpp

Modified: llvm/trunk/lib/Analysis/IndirectCallPromotionAnalysis.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Analysis/IndirectCallPromotionAnalysis.cpp?rev=309346&r1=309345&r2=309346&view=diff
==============================================================================
--- llvm/trunk/lib/Analysis/IndirectCallPromotionAnalysis.cpp (original)
+++ llvm/trunk/lib/Analysis/IndirectCallPromotionAnalysis.cpp Thu Jul 27 18:03:10 2017
@@ -58,7 +58,7 @@ static cl::opt<unsigned>
 // Set the maximum number of targets to promote for a single indirect-call
 // callsite.
 static cl::opt<unsigned>
-    MaxNumPromotions("icp-max-prom", cl::init(2), cl::Hidden, cl::ZeroOrMore,
+    MaxNumPromotions("icp-max-prom", cl::init(3), cl::Hidden, cl::ZeroOrMore,
                      cl::desc("Max number of promotions for a single indirect "
                               "call callsite"));
 




More information about the llvm-commits mailing list