[PATCH] D35960: [MachineOutliner] Cleanup: move findCandidates out of suffix tree

Jessica Paquette via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 27 16:18:37 PDT 2017

paquette marked an inline comment as done.
paquette added inline comments.

Comment at: lib/CodeGen/MachineOutliner.cpp:1054-1055
   std::ostringstream NameStream;
-  NameStream << "OUTLINED_FUNCTION" << "_" << OF.Name;
+  NameStream << "OUTLINED_FUNCTION"
+             << "_" << OF.Name;
MatzeB wrote:
> paquette wrote:
> > MatzeB wrote:
> > > can't you just make this `"OUTLINE_FUNCTION_"`?
> > I think that sounds a little strange, since the function was "outlined"... But it's a character shorter so I'll go ahead and change it.
> OUTLINED is fine a made a typo.
> My point was to do `<< "AB"` instead of `<< "A" << "B"`
Ah, okay! It's silly that it wasn't that before. I'll fix that.


More information about the llvm-commits mailing list