[PATCH] D35880: Un-revert "Teach the CMake build system to run lit's test suite. These can be run"

Brian Gesiak via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 27 12:17:37 PDT 2017


modocache added a comment.

I am definitely a fan of turning these on first, then optimizing to reduce the time it takes for them to run. For the record, with this patch applied locally, `check-all` takes `681.54 real, 3349.92 user, 614.90 sys`, whereas before it took `667.35 real, 3293.70 user, 600.09 sys`. I hope that's acceptable price to pay for keeping lit's own tests passing, at least until we can optimize it to run faster.

I'll land this now, and monitor what happens for the next few hours. I'll revert it if related failures pop up. Fingers crossed! :)


https://reviews.llvm.org/D35880





More information about the llvm-commits mailing list