[PATCH] D35951: Remove the obsolete "offset" parameter from @llvm.dbg.value

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 27 11:42:20 PDT 2017

aprantl added a comment.

In https://reviews.llvm.org/D35951#823038, @dexonsmith wrote:

> Should there also be an update to LangRef?
> In https://reviews.llvm.org/D35951#823015, @aprantl wrote:
> > For those living downstream I should also note that the IR testcase updates are not strictly necessary, since the auto upgrade code also works for assembler input, but I think it is less confusing to have the testcases use the up-to-date version of the intrinsics.
> I feel like it would be better to error, and require the upgrade.  Is that not practical for intrinsics?

LLParser::ValidateEndOfModule() always calls UpgradeCallsToIntrinsic(), therefore special-casing just the debug info intrinsics would be inconsistent.



More information about the llvm-commits mailing list