[PATCH] D35840: All libcalls should be considered to be GC-leaf functions.

[Philip Reames via Phabricator via llvm-commits]

reames added a comment.

In https://reviews.llvm.org/D35840#822809, @anna wrote:

> This change looks good to me. However, I would suggest separating out the `PlaceSafepoints` (and it's testcase) change from the `RewriteStatepointsForGC` change. We don't use placeSafepoint anymore, so we should perhaps just deprecate it upstream, instead of fixing it. 
>  @reames: What do you suggest?


Fixing both is definitely the right answer for the moment.  PlaceSafepoints is questionable.  It's a nice proof of concept, but given we aren't using it and thus testing it, it's probably starting to bit rot.  I'd lean toward removing it, but let's check on llvm-dev to see if anyone else is using it before we just delete the code.


https://reviews.llvm.org/D35840