[PATCH] D35788: [DAGCombiner] Extending pattern detection for vector shuffle.

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 27 03:59:02 PDT 2017


RKSimon added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:14215
   VecIn.push_back(SDValue());
-
   for (unsigned i = 0; i != NumElems; ++i) {
----------------
Very minor - but please keep these newlines - it makes everything easier to understand!


https://reviews.llvm.org/D35788





More information about the llvm-commits mailing list