[PATCH] D35354: [X86][LLVM][TD] Arranging Atom family in an inheritance ratio
Craig Topper via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 26 22:50:27 PDT 2017
craig.topper added inline comments.
Comment at: lib/Target/X86/X86.td:415
Why is CallRegIndirect in BonnellProc and AtomPlusFeatures? Should it be in AtomFeatures instead? Or should each CPU list is separately?
Comment at: lib/Target/X86/X86.td:417
I don't think the "Slow" features should be part of AtomPlusFeatures. While its great for sharing between Silvermont and Goldmont. It makes AtomPlusFeatures hard to inherit from for the processor after Goldmont if it changes any of those things.
More information about the llvm-commits