[PATCH] D35919: [AArch64] Fix callee saved registers in win64 vararg functions with CombineSPBump=0

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 26 21:48:47 PDT 2017

mstorsjo added a comment.

In https://reviews.llvm.org/D35919#822150, @t.p.northover wrote:

> There's far too much ad-hoc hackery going on here for my tastes. This is the 3rd (soon to be 4th) patch trying to get something working, I think it's time to step back and really look at the code that's being modified. Or at least come up with a thorough set of tests.

Yeah. The first approach I had (which redefined the canonical frame address) was ugly but probably didn't have any of these other issues.

I'll try to get all codepaths thoroughly tested here before trying to get the next version landed.


More information about the llvm-commits mailing list