[PATCH] D35396: [lit] Make %T return a per-test temporary directory

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 26 17:27:12 PDT 2017


MatzeB added a comment.

In https://reviews.llvm.org/D35396#822278, @MatzeB wrote:

> The fact that %T has the same values for all tests inside a directory is indeed terrible.
>
> One thing to think about however: With this patch it seems %T and %t both point to a unique name that doesn't exist. So why have %T at all, you could just as well do `mkdir %t` and I think there already are a bunch of tests that do just that.


Should have read the discussion before answering and realize you already discussed all that :)
(Guess there is just the fact that I lean towards the more aggressive solution that drops the concept of %T entirely. But that is easy to say if you're not the one having to fixup all the tests. In any way I'm fine with this approach too.


https://reviews.llvm.org/D35396





More information about the llvm-commits mailing list