[PATCH] D35396: [lit] Make %T return a per-test temporary directory
Kuba (Brecka) Mracek via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 26 17:00:28 PDT 2017
kubamracek added a comment.
In https://reviews.llvm.org/D35396#822242, @rnk wrote:
> In https://reviews.llvm.org/D35396#809760, @kubamracek wrote:
> > > lit already ensures that tmpDir exists, so that's what this change will do. Look for callers of getTempPaths.
> > Oh. That's not what I meant then. I'll update the patch.
> This doesn't seem like it was addressed? As is, surely this will regress lit startup time.
This was addressed, I changed the patch. `dirname(tmpBase)` is later being mkdir'd, but `tmpDir` isn't.
More information about the llvm-commits