[llvm] r309227 - [lit] Fix race between shtest-shell and max-failures tests

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 26 15:57:32 PDT 2017


Author: rnk
Date: Wed Jul 26 15:57:32 2017
New Revision: 309227

URL: http://llvm.org/viewvc/llvm-project?rev=309227&view=rev
Log:
[lit] Fix race between shtest-shell and max-failures tests

Previously these tests would use the same Output directory leading to
flaky non-deterministic failures.

Added:
    llvm/trunk/utils/lit/tests/Inputs/max-failures/
    llvm/trunk/utils/lit/tests/Inputs/max-failures/lit.cfg
Modified:
    llvm/trunk/utils/lit/tests/max-failures.py

Added: llvm/trunk/utils/lit/tests/Inputs/max-failures/lit.cfg
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/tests/Inputs/max-failures/lit.cfg?rev=309227&view=auto
==============================================================================
--- llvm/trunk/utils/lit/tests/Inputs/max-failures/lit.cfg (added)
+++ llvm/trunk/utils/lit/tests/Inputs/max-failures/lit.cfg Wed Jul 26 15:57:32 2017
@@ -0,0 +1,6 @@
+import lit.formats
+config.name = 'shtest-shell'
+config.suffixes = ['.txt']
+config.test_format = lit.formats.ShTest()
+config.test_source_root = os.path.dirname(__file__) + '/../shtest-shell'
+config.test_exec_root = None

Modified: llvm/trunk/utils/lit/tests/max-failures.py
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/tests/max-failures.py?rev=309227&r1=309226&r2=309227&view=diff
==============================================================================
--- llvm/trunk/utils/lit/tests/max-failures.py (original)
+++ llvm/trunk/utils/lit/tests/max-failures.py Wed Jul 26 15:57:32 2017
@@ -1,9 +1,9 @@
 # Check the behavior of --max-failures option.
 #
-# RUN: not %{lit} -j 1 -v %{inputs}/shtest-shell > %t.out
-# RUN: not %{lit} --max-failures=1 -j 1 -v %{inputs}/shtest-shell >> %t.out
-# RUN: not %{lit} --max-failures=2 -j 1 -v %{inputs}/shtest-shell >> %t.out
-# RUN: not %{lit} --max-failures=0 -j 1 -v %{inputs}/shtest-shell 2>> %t.out
+# RUN: not %{lit} -j 1 -v %{inputs}/max-failures > %t.out
+# RUN: not %{lit} --max-failures=1 -j 1 -v %{inputs}/max-failures >> %t.out
+# RUN: not %{lit} --max-failures=2 -j 1 -v %{inputs}/max-failures >> %t.out
+# RUN: not %{lit} --max-failures=0 -j 1 -v %{inputs}/max-failures 2>> %t.out
 # RUN: FileCheck < %t.out %s
 #
 # END.




More information about the llvm-commits mailing list