[PATCH] D35904: [ARM] Add test to check PCS of ARM ABI runtime floating point helpers

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 26 15:43:29 PDT 2017


efriedma added inline comments.


================
Comment at: test/CodeGen/ARM/float-helpers.s:727
+; CHECK-ALL-LABEL: ul2f:
+; CHECK-SOFT:           bl __aeabi_ul2f
+
----------------
This test isn't really great... I mean, you checking for the presence of the important instruction, but you aren't checking for the lack of other instructions.  Maybe use CHECK-NEXT to explicitly check the entire body?  (You can use utils/update_llc_test_checks.py to do this automatically.)


https://reviews.llvm.org/D35904





More information about the llvm-commits mailing list