Fwd: [PATCH] D35908: [YAML] Use {Specific}BumpPtrAllocators for HNodes.

Juergen Ributzka via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 26 13:24:59 PDT 2017



> Begin forwarded message:
> 
> From: Juergen Ributzka via Phabricator <reviews at reviews.llvm.org>
> Subject: [PATCH] D35908: [YAML] Use {Specific}BumpPtrAllocators for HNodes.
> Date: July 26, 2017 at 11:43:25 AM PDT
> To: juergen at ributzka.de
> Cc: hiraditya at msn.com, zturner at google.com
> Reply-To: reviews+D35908+public+a030263ec48807c6 at reviews.llvm.org
> 
> ributzka created this revision.
> Herald added a subscriber: hiraditya.
> 
> The YAML parser already uses a BumpPtrAllocator for all its Nodes, but inside
> YAMLTraits we still use make_unique for HNodes. This results in lot of malloc
> traffic when parsing large or many YAML files.
> 
> Most HNode sub-classes can use a simple BumpPtrAllocator, but there are two
> sub-classes that need SpecificBumpPtrAllocators to call the proper destructor.
> 
> 
> https://reviews.llvm.org/D35908
> 
> Files:
>  llvm/include/llvm/Support/YAMLTraits.h
>  llvm/lib/Support/YAMLTraits.cpp
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170726/5b16eb75/attachment.html>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170726/5b16eb75/attachment-0001.html>


More information about the llvm-commits mailing list