[PATCH] D35724: [ELF] - Fix missing relocation when linking executable with --unresolved-symbols=ignore-all

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 26 11:11:09 PDT 2017


>George Rimar via Phabricator <reviews at reviews.llvm.org> writes:
>> Index: test/ELF/no-inhibit-exec.s
>> ===================================================================
>> --- test/ELF/no-inhibit-exec.s
>> +++ test/ELF/no-inhibit-exec.s
>> @@ -6,7 +6,7 @@
>>
>>  # CHECK: Disassembly of section .text:
>>  # CHECK-NEXT: _start
>> -# CHECK-NEXT: 201000: {{.*}} callq -2101253
>> +# CHECK-NEXT: 201000: {{.*}} callq 0
>
>Please add a test of produced dynamic relocation.

btw, in this testcase there will be no relocations (because output is static), 
I added the check and will update diff soon.

But patch contains another testcase which checks the produced relocation for
-pie case.

George.


More information about the llvm-commits mailing list