[PATCH] D35891: [Support/GlobPattern] - Do not crash when pattern has characters with int value < 0.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 26 10:16:30 PDT 2017


ruiu added inline comments.


================
Comment at: lib/Support/GlobPattern.cpp:39
     if (S[1] != '-') {
-      BV[S[0]] = true;
+      BV[(uint8_t)S[0]] = true;
       S = S.substr(1);
----------------
Instead of casting to `uint8_t`, cast to `unsigned`.


https://reviews.llvm.org/D35891





More information about the llvm-commits mailing list